gh-155727: Ignore internal imports in test_attribute_completion - #155730
Merged
serhiy-storchaka merged 1 commit intoAug 14, 2026
Merged
Conversation
Reader.run_hooks() imports _pyrepl._threading_handler lazily, and the test counted it as a module imported by the completer.
serhiy-storchaka
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
August 13, 2026 15:37
serhiy-storchaka
added
needs backport to 3.15
vstinner
approved these changes
Aug 13, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. The change fix the test as expected.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-155769 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
mbeijen
pushed a commit
to mbeijen/cpython
that referenced
this pull request
Aug 14, 2026
…pythonGH-155730) Reader.run_hooks() imports _pyrepl._threading_handler lazily, and the test counted it as a module imported by the completer.
hugovk
pushed a commit
that referenced
this pull request
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore
_pyreplsubmodules when comparing the modules imported while the reader runs.